Cache item info, reducing time of crafting filter d:
to ~32%
#78945
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance "Cache item info, reducing time of crafting filter
d:
to ~32%"Purpose of change
d:
is notoriously slow.short string
info generates too long (725 ms) #78749 - Didn't measure the results and there is more to be done.Describe the solution
const recipe_subset available_recipe_subset
, make it a reference. See testing.can_craft_recipe
, like in Cache item info for crafting GUI full-text search #77914Describe alternatives you've considered
Testing
I had it on for a while and noticed this makes a significant difference for
d:
filter, as shown by profiling:Original code.
Note:
Making it a reference - first commit.
Note:
Making cache - second commit.
Note:
can_make
about 10 times.Additional context
short string
info generates too long (725 ms) #78749 too, but I don't care to test it now.