Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desert Region] Rework canyon variation as same id omts using parameters and z nests #78899

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jan 2, 2025

Summary

None

Purpose of change

Since this was written there's a cooler way
Ideally I want to improve the canyon mutable enough to replace ravine overmap hardcoding

Describe the solution

Replaces the ided variants with single id maps where the variant is instead controlled by parameter picked nests that are all placed from a single omt to guarantee each vertical column has the same parameter in leui of appropriate scoping #73021

Describe alternatives you've considered

Will probably do the same with the mesa in a follow-up PR
Will hopefully replace hardcoded ravine overmap gen used solely in aftershock exoplanet with an improved canyon mutable in a followup PR
Making the canyon omts linear by z level but that seems overkill rn

Testing

Looks the same in game as far as I can tell, haven't tested migration yet

Additional context

@Procyonae Procyonae marked this pull request as draft January 2, 2025 01:38
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Desert Region Anything relating to the Desert Region mod json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 2, 2025
@Procyonae Procyonae marked this pull request as ready for review January 2, 2025 16:06
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 2, 2025
@Procyonae Procyonae marked this pull request as draft January 3, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Desert Region Anything relating to the Desert Region mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant