-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune nanofab_recipes #78859
Prune nanofab_recipes #78859
Conversation
I'll need to re arrange the entirety of the list with (or after) #76582. Not a bad change for now tho. |
c9e4429
to
90e1160
Compare
90e1160
to
811b34c
Compare
!?!??!?! Nanofab is for fun, exotic end-game items. They do not exist in real life, that's the whole point. Are items not added here specifically to make them available but keep them out of any other conceivable loot pool where the pedestrian top-side theme is important?? If nanofab isn't an acceptable place for high tech items, what is?
People literally already do use a 3D printer to print otherwise impossible to manufacture lattice structures. If the nano structure is complex enough, this is a perfectly reasonable use case. If the lore is inaccurate or unclear, you should change it instead of defaulting to removal. |
This comment was marked as abuse.
This comment was marked as abuse.
Its salvaged alien technology, it'll get a new list that reflects this. |
@KHeket Read the code of conduct before posting again. In particular, you must refrain from making inflammatory remarks or assuming bad faith. |
Summary
Bugfixes "Polish up nanofab recipes"
Purpose of change
We have a few nanofab recipes for items that either don't make sense to be nanofabbed, or aren't earth native.
G80 railgun stuff: Spawns in voidweaver pools, aren't earth-native, therefore shouldn't be in here.
Alloy plate: What super alloy is is a bit vague, but a single solid sheet of one material seems like a waste of an intricate machine, akin to using a 3d printer to print out square sheet of plastic.
Plasma gun: Voidweaver pools, see above.
Can sealer: A joke
UPS: It appears to be a pretty basic electrical device, no reason to use an expensive machine and expensive materials to produce it.
Atomic coffeepot: This is a civilian commercial product, akin to using a nanofab to produce an iphone.
Describe the solution
Removes recipes.
Describe alternatives you've considered
Remove the laser stuff, as that also feels a bit too high-tech
Testing
These are the recipes that were spawned in before the changes, after the changes applied. Everything still works fine.
Here's the results of the new itemgroup
Additional context
Paging @John-Candlebury for input. I know this is kinda your baby, so I want to know if there's anything more you want removed, or anything you want to remain, or anything you want added. This PR will remain in draft until I get your input.