Update thermal gear power draw in tool_armor.json #78832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied values from CleverRaven#78798 (comment) Changed: thermal socks power draw thermal suit power draw, battery flag, and default battery thermal gloves power draw thermal mask power draw thermal outfit power draw
|
You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub. |
github-actions
bot
added
[JSON]
|
Whoops, did not know about branches |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied values from here to thermal electric (TE) gear.
Changed:
TE socks power draw
TE power draw, battery flag, and default battery
TE gloves power draw
TE mask power draw
TE outfit power draw
Summary
Balance "Thermal electric gear power draw reduction + medium battery for TE suit"
Purpose of change
Currently, the thermal electric outfit eats through a medium battery in seven minutes. This PR reduces the power draw of all thermal electric gear to a total of 5 W for the TE outfit. It also changes the thermal electric suit to use a medium battery instead of a light one, along with changing the battery flags for that item. See IdleSol's comment in Issue #78798
Describe the solution
Updated the on variants to new power draws:
Also changed TE suit magazine flag restriction to BATTERY_MEDIUM and default magazine to medium_battery_cell
Describe alternatives you've considered
Considered letting the TE suit also reload with light batteries, but the outfit doesn't take light batteries so I stuck with what IdleSol said. Also considered lowering the power draw to a total of 4 or even 2 W, but 5 W is manageable.
Testing
Additional context