Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add technomantic augmentation clinic #78829

Merged
merged 8 commits into from
Dec 30, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 29, 2024

Summary

Mods "[Magiclysm] Add technomantic augmentation clinic"

Purpose of change

Unlike our Earth, Magiclysm's Earth had CBMs before the Exodii showed up because they were invented by technomancers. However, there's no real evidence of this in the game at the moment, and there should be.

Describe the solution

Add an augmentation clinic, where technomancers or rich people who didn't care about their mana levels had CBMs installed. They're pretty rare and only appear in major cities (Magiclysm Earth had CBMs but they weren't exactly common).

First floor:
Floor1

Waiting room, consultation rooms, the Ritual Room™, and a recovery room with resting area. The autodoc is custom furniture to represent the different path Magiclysm Earth took (for example, if you disassemble it, you get some mana crystals back).

Second floor:
Floor1

Offices for technomancers and bionic storage on the second floor. The bionic storage may have magical defenses...

Describe alternatives you've considered

Testing

Map spawns in and looks pretty good.

We'll see if it complains about carpet parameters.

Additional context

You should be able to find zombies with CBMs in them that were former technomancers (or rich people), now that I think about it. #78796 should make blithely cutting into them feel pretty bad.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Bionics CBM (Compact Bionic Modules) Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Magiclysm Anything to do with the Magiclysm mod labels Dec 29, 2024
@github-actions github-actions bot requested a review from KorGgenT December 29, 2024 05:21
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 29, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This annual publication covers the latest advances in bionic technomancy, the implanation of metal into flesh. There are some pretty promising new developments in here that will now never see the light of day.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Standing-Storm
Copy link
Contributor Author

@Milopetilo Sorry for ping, but the tests are complaining about mapgen 'palette magiclysm_augmentation_clinic' uses undefined parameter 'carpet_color_type' but as far as I can tell I did everything correctly (and it all works in game, as the pictures show). You have more experience with this than me--is there something obviously wrong with my palette?

@QuillInkwell
Copy link
Contributor

QuillInkwell commented Dec 29, 2024

I took a look and it seems like you're the only one using the carpet palette nested inside of another palette. I think that's the issue, the test. I'm guessing it doesn't check nested palettes for the parameters they provide. I'm betting it only looks at palettes directly referenced on the mapgen itself.

And I just checked and yep there is already an issue open for this: #78003 I probably should have opened with that. 🙃

@Standing-Storm
Copy link
Contributor Author

Extra annoying that everything works in-game, then, but at least it's already a tracked error. Thank you!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 29, 2024
@Maleclypse Maleclypse merged commit 9a59660 into CleverRaven:master Dec 30, 2024
20 of 26 checks passed
@Standing-Storm Standing-Storm deleted the hospital-cbms-magiclysm branch December 30, 2024 14:32
@Milopetilo
Copy link
Contributor

@Standing-Storm Sorry for the late response. As Quill said, there's an issue open for this exact thing, but from what I can remember the error showed up when loading into the game so the fact that there's no error for you is pretty weird.
The mapgen still loading in and having carpet is due to the fact that it should be using the fallback, but in your screenshots there's green carpet and in the mapgen file the fallback was red, I'll take a closer look at this once my exams are over :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants