Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Fix wands #78825

Merged
merged 6 commits into from
Dec 29, 2024
Merged

[Magiclysm] Fix wands #78825

merged 6 commits into from
Dec 29, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "[Magiclysm] Fix wands"

Purpose of change

Someone reported to me before Shabbat that they tried to use a wand and it was worthless. It's my fault--since all damaging spells now scale with the caster's spell level, wands that use those spells do minimum damage if the wand-user doesn't know the spell--so time to fix it.

Describe the solution

Make wand versions of the damaging spells like Point Flare and Magic Missile that follow the old format and link the wands to those instead.

Describe alternatives you've considered

Testing

Additional context

I want to add more wands, like a Wand of Sowing (Turning of the Earth) or a Wand of Harden Earth or a Wand of Dimension Door, but one thing at a time.

@github-actions github-actions bot requested a review from KorGgenT December 29, 2024 00:00
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 29, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • BOSTON WAND BUST NABS THREE\n\nOfficers with the Bureau of Alcohol, Thaumaturgy, and Firearms have seized almost 60 wands, including greater combat wands, during the arrest of three Italian nationals in Boston yesterday. Davide Messina, 34, Michele Pellegrino, 29, and Lokúr Santoro, 128, all of Rome, Italy, are being charged with three counts of wand trafficking as well as two counts of conspiracy. The charges allege that Messina, Pellegrino, and Santoro met with an unnamed party as part of a smuggling operation to transport combat wands through America to final destinations in Central and South America.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 29, 2024
@Maleclypse Maleclypse merged commit 5f4fa81 into CleverRaven:master Dec 29, 2024
21 of 26 checks passed
@Standing-Storm Standing-Storm deleted the fix-wands branch December 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants