Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Monster Names #78822

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Holli-Git
Copy link
Contributor

Summary

None

Purpose of change

We have a lot of rather forced alliterations, which can both subtract from the experience of playing as you're distracted by the silly names, and confuse people as sometimes to make the alliteration work the name is not descriptive of what the monster is. This PR is also open to change other poorly-named monsters, if you have suggestions please leave them below.

Describe the solution

Renames them.

Describe alternatives you've considered

Not doing this.

Testing

Dawg it's just title changes

Additional context

In case you didn't read this part in the purpose of change, please suggest any other names you'd like changed. Keeping this PR as a draft for suggestions.

@Holli-Git Holli-Git marked this pull request as draft December 28, 2024 19:22
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Dec 28, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • fursuited zombie
  • fursuited zombies

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 28, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 28, 2024
@Daved27hundred
Copy link
Contributor

I'm guilty of this too:

  • Smoldering Stallion, smoker evolution of the zombie horse. I want to suggest "smoldering mule" since just "horse" sounds lame, even though mules are different from horses altogether, but that's just me being picky.
  • Pestilent Prancer, the spitter evolution of said horse. Just change it to "pestilent horse" since that was its original name.
  • Miracle Lurker, a regenerating zombie medic and a play on "miracle worker." My worst one yet and possibly the worst name in the game ever. I suggest just "regenerating doctor" or "regenerating medic."

@qaziquza
Copy link

Personally, I feel like the alliteration adds gameplay flavour. And if they aren't descriptive (which they are, I think, in most cases) then the player can just ; look at them.

@Holli-Git
Copy link
Contributor Author

I'm guilty of this too:

* Smoldering Stallion, smoker evolution of the zombie horse. I want to suggest "smoldering mule" since just "horse" sounds lame, even though mules are different from horses altogether, but that's just me being picky.

* Pestilent Prancer, the spitter evolution of said horse. Just change it to "pestilent horse" since that was its original name.

* Miracle Lurker, a regenerating zombie medic and a play on "miracle worker." My worst one yet and possibly the worst name in the game ever. I suggest just "regenerating doctor" or "regenerating medic."

Tbh I find smouldering stallion to be like dissoluted devourer. It doesn't feel forced, and it also tells you what the thing is. I'll change miracle lurker though

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 29, 2024
@Uwuewsky
Copy link
Contributor

Uwuewsky commented Dec 29, 2024

Malicious mane sounds pretty cool and clever to me.

please suggest any other names you'd like changed

Here are a couple names that aren't great, though I can't come up with better replacements for them.

Details

zed_amphibian has generally rather odd names.


"name": { "str": "well dressed feral" },

Ability is explicitly stated in the name:

"name": { "str": "zombie necromancer" },

"name": { "str": "zombie necro-boomer" },

These ones have names that are too similar:

"name": { "str": "grabber zombie" },

"name": { "str": "grappler zombie" },

"name": { "str": "screecher zombie" },

"name": { "str": "shrieker zombie" },

And the names of the zed animals have already been pointed out.

@Holli-Git
Copy link
Contributor Author

Here are a couple names that aren't great, though I can't come up with better replacements for them.

Tbh I've never had an issue with those names. Though yeah some zombie amphibians I can tackle

@Maarifrah
Copy link
Contributor

Zeindeer. Zombie reindeer.

@Holli-Git
Copy link
Contributor Author

Zeindeer. Zombie reindeer.

Also changed fungideer

@Holli-Git Holli-Git marked this pull request as ready for review December 31, 2024 18:03
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 31, 2024
@tenehea

This comment was marked as abuse.

@Zireael07
Copy link
Contributor

No, only some did, not "every single one". Some sounded forced and made things unnecessarily difficult for translators.

@@ -154,7 +154,7 @@
{
"id": "mon_zombullfrog",
"type": "MONSTER",
"name": { "str": "zombullfrog" },
"name": { "str": "zombie bullfrog" },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be left as is. We have a set of other zombie animals which names consist of "zom + original animal name", like zombull, zombear, zombeaver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.