NPC should not wield integrated armor #78810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
osuphobia
changed the title
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "NPC should not wield integrated armor"
Purpose of change
Fix #78780
Describe the solution
Add a flag_INTEGRATED check to can_wield, add can_wield check for NPC behavior.
Describe alternatives you've considered
Only add flag_INTEGRATED for NPC behavior.
Testing
NPC no longer wield integrated armor.
Also PC will see a failure msg about integrated armor in wield item menu.
Additional context
While testing this PR, I found that NPC never tries to attack with his bare hand, with or without this patch. Trying to tweak relevant functions resulting in infinite loop, so I'd leave it to somebody else to figure out.