Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more sigint-related fixes #78794

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RenechCDDA
Copy link
Member

@RenechCDDA RenechCDDA commented Dec 27, 2024

Summary

None

Purpose of change

Resolve issues described in #77636 (comment)

Intended to supersede #78791

Describe the solution

Check for SIGINT in character creation window

Check for SIGINT in options window and string query popup

Describe alternatives you've considered

Testing

Press alt-f4 in character creation, program terminates.

Additional context

Currently does not account for query_exit_to_OS() or other technicalities. Figuring out the problems first, then making it 'proper'

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 27, 2024
@ZhilkinSerg
Copy link
Contributor

In current state, helps with Alt+F4 in new character menu when there are no popups open, but it does not resolve the issue with popups delaying exit after Alt+F4 (which is expected as no related code was touched).

@RenechCDDA RenechCDDA force-pushed the remove_fun_using_sigint branch from b880d79 to 0e661d9 Compare December 27, 2024 15:46
@RenechCDDA RenechCDDA force-pushed the remove_fun_using_sigint branch from 0e661d9 to 3474193 Compare December 27, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants