Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes damage from archery bracers, adds weakpoint accuracy. #78731

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

CwasCard
Copy link
Contributor

Summary

Mods "Changes a straight damage on archery bracers to weakpoint accuracy."

Purpose of change

#76663 Standing Storm wished to change straight damage to weakpoint accuracy when possible, so this change does that.

Describe the solution

Adds weakpoint accuracy to archery bracers. I'm not exactly sure just how likely you are to hit weakpoints, but given high armor values & investment into archery to start hitting weakpoints to begin with (skill training, proficiency training) and the original wording of "making archery competitive with guns", I can only assume a high weakpoint accuracy modifier's the way to do it.

Describe alternatives you've considered

Adding flat armorpiercing value, adding multiple pairs of bracers with tiered effects from minor to "this is actually better than a gun". I tried making the weakpoint multiplier scale heavily off of archery skill, but the game didn't like me putting a math function in the multiply field.

Testing

Set Weakpoint Accuracy in the JSON to 1, all proficiencies & all skills to 10. Shoot a skeletal juggernaut a few times, notice that I'm not hitting their eyes? Set it to 99, notice lots of eye hits, set it to 2.5 as a nice middle ground when compared to expected lilin Ruach pool as per #77576

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod labels Dec 22, 2024
@github-actions github-actions bot requested a review from KorGgenT December 22, 2024 22:06
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 22, 2024
@Standing-Storm
Copy link
Contributor

Thank you for doing this!

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 23, 2024
@Standing-Storm
Copy link
Contributor

the game didn't like me putting a math function in the multiply field.

Missed this the first time--what was the complaint? There's no conceptual reason why this shouldn't work

@CwasCard
Copy link
Contributor Author

Right, I've changed the math effect to an enchantment effect. Does it scale too intensely? If not, then it's finished.

Comment on lines 121 to +125
"values": [
{ "value": "RANGED_DAMAGE", "multiply": 0.25 },
{ "value": "RANGE", "multiply": 0.2 },
{ "value": "WEAPON_DISPERSION", "multiply": -0.33 }
],
"ench_effects": [ { "effect": "effect_plus_two_to_hit", "intensity": 1 } ]
"ench_effects": [ { "effect": "effect_plus_two_to_hit", "intensity": 1 }, {"effect": "archerybracers", "intensity": 1}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"values": [
{ "value": "RANGED_DAMAGE", "multiply": 0.25 },
{ "value": "RANGE", "multiply": 0.2 },
{ "value": "WEAPON_DISPERSION", "multiply": -0.33 }
],
"ench_effects": [ { "effect": "effect_plus_two_to_hit", "intensity": 1 } ]
"ench_effects": [ { "effect": "effect_plus_two_to_hit", "intensity": 1 }, {"effect": "archerybracers", "intensity": 1}]
"values": [ { "value": "RANGE", "multiply": 0.2 }, { "value": "WEAPON_DISPERSION", "multiply": -0.33 } ],
"ench_effects": [ { "effect": "effect_plus_two_to_hit", "intensity": 1 }, { "effect": "archerybracers", "intensity": 1 } ]

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Dec 25, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Standing-Storm
Copy link
Contributor

100% better per point of archery is pretty high--I might change it to archery / 3 or something (so it's still very high for a master but not just constant bullseyes).

Comment on lines +1710 to +1711
"enchantments": [ { "values": [ {"value": "WEAKPOINT_ACCURACY", "multiply": {"math": [ "1+((u_skill('archery'))/3)" ]}}]}]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"enchantments": [ { "values": [ {"value": "WEAKPOINT_ACCURACY", "multiply": {"math": [ "1+((u_skill('archery'))/3)" ]}}]}]
"enchantments": [ { "values": [ { "value": "WEAKPOINT_ACCURACY", "multiply": { "math": [ "1+((u_skill('archery'))/3)" ] } } ] } ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants