Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Vertical Movement While Levitating and Flying #78686

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

b3brodie
Copy link
Contributor

Summary

Infrastructure "Streamline Vertical Movement While Levitating and Flying"

Purpose of change

Moving up and down while flying or levitating has a good amount of unneeded checks that are inherited from normal vertical movement logic, but they don't make sense for flight and only give extra keypresses.

Describe the solution

Levitating:

  • If there is a viable spot directly below the player, just automatically choose that instead of asking for other adjacent areas.
  • Do not ask again if the player truly wants to move there since the levitation flag guarantees that the move will be successful

Flying:

  • Don't require viable arms or not holding a two handed weapon. Since players aren't climbing they don't need their hands
  • Just go directly up instead of asking for alternative locations when nearby a wall.

Describe alternatives you've considered

N/A

Testing

Moved up and down while flying with ethereal wings and didn't get useless popups.
Moved up while holding a zweilander successfully.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant