Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title menu tileset layering error #78670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShnitzelX2
Copy link
Contributor

Summary

Bugfixes "Fix title menu tileset layering error"

Purpose of change

Describe the solution

Refreshing tiles only should happen in-game, so now refreshing tiles from the options menu checks if core data is loaded.

This also makes switching tilesets on the title screen much faster.

Describe alternatives you've considered

Testing

Changed the tileset in-game and on the title menu according to the issue, no errors.

As recently reported, Tiles = false is currently segfaulting the game, so I can't test that right now

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing tileset on the main menu moans about layering ids not existing
1 participant