Fix place terrain special performance #78663
Merged
+86
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
Procyonae
force-pushed
the
FixPlaceTerrainSpecialPerformance
branch
from
9cf953a to
cdeb995
Compare
github-actions
bot
added
the
BasicBuildPassed
…erwise stuff will probably be borked, dupe functionality to tiles
github-actions
bot
added
the
NPC / Factions
github-actions
bot
removed
the
BasicBuildPassed
Procyonae
force-pushed
the
FixPlaceTerrainSpecialPerformance
branch
from
7650f5c to
240b881
Compare
github-actions
bot
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #77341
Describe the solution
Stores whether omt was generated rather than checking every frame
Swaps the check for a cheaper approximate one seeing as we're not worried about some inaccuracies
Adds vertical and mouse movement + fixes coordinate type for overmap mouse movement
Move other calls to lookup_submap over to submap_exists where appropriate
Describe alternatives you've considered
I want to fix the off by one thing with mouse movement but that seems more awkward than I were hoping
Testing
Drastically less laggy with ascii and tiles
Additional context