Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General map editor improvements #78656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

I were annoyed that traps were shown by name and not id

Describe the solution

Normalise ter/furn/trap/field formatting and order them together
Add mouse movement
Remove curses only bind from being displayed on tiles
Remove non useful bind descriptors from the menu (Quitting the menu, HJKL fast movement)
Remove omt cycle binds from omt editor submenu bc they don't mesh at all well with the newish list functionality that supercedes them
Increase the width of the main window a bit so it overflows less often (still frequently overflows with long ids or lots of flags etc)

Describe alternatives you've considered

Removing int_ids?
Doing more but I feel that'd be best left for when it's imguified

Testing

Tested all changes on tiles and curses

Additional context

Before tiles/curses
image image

After tiles/curses
image image

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Furn: %s (%d); move cost %d; movestr %d
  • Ter: %s (%d); move cost %d

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Night-Pryanik
Copy link
Contributor

I was thinking about this kind of improvements like for years. Thank you for doing this!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants