-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Small Lighthouse Tower Floor #78628
base: master
Are you sure you want to change the base?
Fix Small Lighthouse Tower Floor #78628
Conversation
Just mostly reused the old PR text for times sack but in short I added a new tile which is indoors so that the old one doesn't conflict with sky island. So @harakka is now able to change the structure so it uses both |
This PR doesn't currently fix anything since the terrain you added isn't used anywhere. You can do it trivially yourself, add it to the palette in |
Thanks for telling me that. I know literally nothing about map-making in this game but I guess there's no time like the present. Any other resources I should know about for future reference? |
Does this work @harakka? |
Yes, this will do. |
Fix Small Lighthouse Tower Floor
Bugfixes: Lighthouse tower properly marked as inside space**
Summary
Bugfixes "Lighthouse tower properly marked as inside space"
Purpose of change
Fixes #78553.
Currently, the small lighthouse tower is marked as outside despite being enclosed with:
t_stone_masonry_floor
),This causes unintended behavior, such as rain falling indoors. This PR ensures the lighthouse tower is correctly marked as an inside space.
Describe the solution
t_stone_masonry_floor_balcony
tile which is considered an inside floor.Describe alternatives you've considered
Replace the
t_stone_masonry_floor
tiles specifically for the lighthouse with another floor tile (e.g.,t_wood_floor
ort_tile
) to mark the space as inside. Please consider doing this @harakka so that sky island isn't affectst_stone_masonry_floor
.Notes
t_stone_masonry_floor
globally is problematic, I will adjust the tiles specific to the lighthouse area.