Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bagpipes Volume Change #78626

Closed

Conversation

WhaleYogurt
Copy link
Contributor

Bagpipes volume change

Summary

Balance "Increase bagpipe volume from 24 to 75"

Purpose of change

This change addresses the request to make bagpipes significantly louder. The current volume of 24 was too low to match the intended gameplay effect of the instrument. This adjustment increases the volume to 75, making it more realistic and impactful as a tool for gathering the horde.

This change relates to issue #78608: "Bagpipes should be LOUD".

Describe the solution

The volume for the bagpipes was increased in the JSON file from 24 to 75. This increase better represents the auditory range of bagpipes.

File modified:
data/json/items/tool/musical_instruments.json

Describe alternatives you've considered .

  • Intermediate values (50-75) were considered, with 75 chosen as a reasonable compromise for realism and gameplay impact.

Testing

  • Verify the sound range increase in-game.
  • Confirmed that the change is isolated to the bagpipe's volume property.
  • No errors or unexpected behavior occurred during testing.

Additional context

  • Bagpipes are traditionally loud instruments that can be heard across long distances, especially in quiet environments.
  • Apparently they can be about as loud as a chainsaw so 24 seemed way to low

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 17, 2024
@GuardianDll
Copy link
Member

oh, volume like noise volume
i wondered why you change the item volume (dimensions) if your issue was about volume (loudness)

@WhaleYogurt WhaleYogurt closed this by deleting the head repository Dec 17, 2024
@GuardianDll
Copy link
Member

Hmm? Why closed? Seems reasonable for me

@WhaleYogurt
Copy link
Contributor Author

Sorry that was a mistake I was trying to clean up my page and something went wrong

@GuardianDll
Copy link
Member

it seems you removed your entire repo, need to make a fork again

@WhaleYogurt
Copy link
Contributor Author

made a new fork. should have pushed it too

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants