Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybindings for throw and blind throw of wielded item #78625

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

MrDraMaster
Copy link
Contributor

@MrDraMaster MrDraMaster commented Dec 17, 2024

Summary

Features "Add keybind to throw your wielded item"

Purpose of change

Manually selecting the wielded knife pulled from the bag of infinite throwing knives is annoying.

Resolve #69113

Describe the solution

Look what #36658 did for reloading and do the same for throwing. Then find out that peek-throwing is a separate keybind, so duplicate that for wielded as well.

Describe alternatives you've considered

Continue waiting for someone else to implement my suggestion.

Testing

normal throw

  1. load character with no config/keybinds.json, check for unbound "Throw wielded item" ✔️
  2. bind a key, make sure nothing is wielded, press the key => "You aren't holding something you can throw." message is logged ✔️
  3. wield something, then press the key => throw-aiming screen for the wielded item opens, wielded item can be thrown ✔️

blind throw while peeking

  1. peek, then check for unbound "Blind throw wielded item" ✔️
  2. bind a key, make sure nothing is wielded, press the key => "You aren't holding something you can throw." message is logged ✔️
  3. wield something, peek, then press the key => blind-throw-aiming screen for the wielded item opens, wielded item can be blind-thrown ✔️

Additional context

My random test character was a tourist swimmer with a beach volleyball which made for great throwing practice 😄

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 17, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Qrox

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 17, 2024
@Night-Pryanik Night-Pryanik merged commit 677a4f1 into CleverRaven:master Dec 18, 2024
26 of 29 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 18, 2024
@MrDraMaster MrDraMaster deleted the throw-wielded-item branch December 19, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keybind to throw wielded item
2 participants