yet another portable charcoal kiln audit

[marilynias]

Summary

Balance "make charcoal kiln place-able"

Purpose of change

while tackling #78619 I found that the char_kiln implementation was kind of a mess where each step has its own item, you need to craft to fill the kiln with wood and uncraft to receive the final product, while the furniture (with its own independent construction recipe) had a lot more intuitive kilning process. This PR seeks to unite them.
resolves #78619.

Describe the solution

• replace the construction ingredients of the furniture kiln with the char_kiln item and adjust requirements
• add deploy action to char_kiln
• obsolete the 3 step-items and their recipes

Describe alternatives you've considered

Only fixing lit kiln size. As seen in the issue, but there will be mistakes/missed items in the future.

Testing

Craft, deploy, deconstruct kiln.
Load save with all 4 stages of the kiln to ensure migration works. (will loose the wood/charcoal inside)

Additional context

The process for f_kiln_metal_empty is all in c++, maybe its possible to EOC'ify it?

[IdleSol]

Pay attention. These are different kilns. The stationary one is 250 liters. That's why it's made of 4 tanks. You're using a 60-liter "mobile" kiln.

And if I remember correctly, they have different material to coal conversion ratios.

Anyway, I'm against this PR in its current form.

UPD.

• Auditing portable charcoal kiln #77139

[marilynias]

Pay attention. These are different kilns. The stationary one is 250 liters. That's why it's made of 4 tanks. You're using a 60-liter "mobile" kiln.

And if I remember correctly, they have different material to coal conversion ratios.

thanks, quick opinion check;
Is it desired to have 2 different metal kilns? (one small one big), in which case ill revert to just fixing the original issue.
If not, which one should be the default one? Since there are no reference models, ill reference
CharcoalProduction.pdf p8-15.
the conversion rates are very similar (~30% vs 28-30%).

[IdleSol]

My personal opinion. There must be two versions:

1. A stationary one with high efficiency
2. Mobile, with less efficiency

The way it is now. I base it on the fact that we have mobile and stationary smokehouses. And if you have a mobile base, it's more convenient for you to carry the mobile versions.

Cataclysm-DDA/data/json/items/tool/deployable.json

Line 229 in c085521

"id": "metal_smoking_rack",

Cataclysm-DDA/data/json/furniture_and_terrain/furniture-tools.json

Line 645 in c085521

"id": "f_metal_smoking_rack",

and

Cataclysm-DDA/data/json/furniture_and_terrain/furniture-tools.json

Line 500 in c085521

"id": "f_smoking_rack",

As for changes. You can just add new furniture ~ f_kiln_metal_empty_small or f_kiln_metal_empty_mobile or whatever. I'm bad at English. Then the mobile would be set on the ground before use. Which will give you what you want.

[IdleSol]

The volume of the item (char_kiln) is 201 liters. And if you place it (f_kiln_portable_empty), it has a volume of 250 liters. I may be wrong, but this 250 liters is the internal volume.

It's supposed to be 200 liters? But I'm not sure it is.