Don't assign missions during testing #78614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
RenechCDDA
force-pushed
the
kill_test_error
branch
from
8424d01 to
b977ee1
Compare
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/12359934654/job/34493740159?pr=78524#step:19:105
"completed mission MISSION_CAMP_LEADERSHIP_CHANGE was not in the active_missions list"
This has persisted and caused numerous failures despite repeated attempts to resolve it.
Describe the solution
Just stop it from running during the tests. We're not testing it, so we don't need it to run.
This is accomplished by overriding the EOCs that call it in the TEST_DATA mod, which is always loaded.
Describe alternatives you've considered
Maybe we could configure the EOC/event infrastructure to not listen during testing, but this seems much simpler.
Testing
Additional context