Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: use the O(log(n)) instead of O(n) method #78569

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Dec 14, 2024

Summary

None

Purpose of change

I used O(n) and complicated the way of getting itype from itype_id in:

Describe the solution

Use the correct and faster method.

Describe alternatives you've considered

Testing

  1. Launch the game.
  2. Try filters L:122 cm in AIM and crafting GUI.
  3. Observe: They throw no errors and work.

Additional context

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 14, 2024
@Brambor Brambor marked this pull request as draft December 14, 2024 17:48
@Brambor Brambor marked this pull request as ready for review December 14, 2024 17:52
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 15, 2024
@Maleclypse Maleclypse merged commit 7acb286 into CleverRaven:master Dec 15, 2024
25 checks passed
@Brambor Brambor deleted the filter-log-n branch December 16, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants