Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backport #77665 #78568

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

Night decided to merge #78545 despite it failing Basic Build before I had a chance to notice

Describe the solution

Correct the eoc function used to the old old one instead of the old one

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 14, 2024
@Maleclypse Maleclypse merged commit c26c229 into CleverRaven:0.H-branch Dec 15, 2024
21 of 24 checks passed
@Maleclypse
Copy link
Member

@Night-Pryanik no stress ping, I had the same experience of not knowing that there aren't any merge protections on non-master branches and we can accidentally merge things that don't pass basic build for backport PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants