Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COMPILING-VS-VCPKG.md #78561

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

CoreyHendrey
Copy link
Contributor

Summary

None

Purpose of change

I was having trouble building the game, and realised it was a silly path issue (I had "+" in the path). The documentation notes no whitespace, but doesn't mention not having special symbols.

Describe the solution

Just added a note and an example about special symbols in the vcpkg path

Testing

It didn't work with the symbols, I noticed that it said the command was invalid in the log. Removed the symbols, and I am building the game.

Added warning about special symbols in VS build instructions
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs new contributor astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 14, 2024
@kevingranade kevingranade merged commit 0974229 into CleverRaven:master Dec 14, 2024
16 of 20 checks passed
b3brodie pushed a commit to b3brodie/Cataclysm-DDA that referenced this pull request Dec 16, 2024
Added warning about special symbols in VS build instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants