Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg to new mainline commit and instructions #78548

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Dec 13, 2024

Summary

Build "Update vcpkg commit to new mainline, remove portfile override"

Purpose of change

New devs setting up with vcpkg are having a hell of a time because the 'blessed' commit doesn't work with newer vcpkg binaries. Older vcpkg binaries no longer recognize new VS2022 installs. There is a range of binaries which would work, but it's unnecessarily complicated to require that. Updating simplifies the setup process by not requiring a convoluted two step checkout.

Describe the solution

Update the vcpkg commit in docs and github workflows.

Describe alternatives you've considered

Complicating the vcpkg setup further at risk of encountering even more breakages down the line.

Testing

Check out a new vcpkg commit. Build locally in debug and release modes, with llvm thin archives enabled, and fix the resulting linker errors. Validate the builds run. Sounds are not glitchy (confirmed the sdl2 release includes Qrox's remixer fix). grep for the old commit hash to ensure it's gone.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Code: Tooling Tooling that is not part of the main game but is part of the repo. Code: Build Issues regarding different builds and build environments astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 13, 2024
@Night-Pryanik Night-Pryanik merged commit 00c49c4 into CleverRaven:master Dec 14, 2024
27 checks passed
@akrieger akrieger deleted the tis_the_season_for_vcpkg branch December 14, 2024 04:45
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants