Fix perspective shift in construction #78493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #78489. I broke logic which restored the UI after construction because I misunderstood the side effects of the code in question.
Describe the solution
The old code wrapped the
restore_on_out_of_scope
in aunique_ptr
to allow manually triggering the restore. The broken code was instead cancelling the restore entirely. Put theunique_ptr
logic back because that is correct. Keeprestore_on_out_of_scope::cancel()
because it might still be useful later.Describe alternatives you've considered
Testing
It's putting the old logic back so it should Just Work (tm).
Reproduced the issue. Applied the fix. Entered and exited construction workflow and view did not stay shifted.
Additional context