[Magiclysm/Xedra Evolved] Animals can't do that #78472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Magiclysm/Xedra Evolved] Animals can't do that"
Purpose of change
I've been adding a lot of ability to shapechange into various animals in different mods and part of my goal is reasonable restrictions on what those animals can do. Code support will have to wait for limbification, but in the meantime,
u_cancel_activity
can cover a lot of things.Describe the solution
Add an EoC that runs
u_cancel_activity
shortly after starting a huge variety of activities. You shouldn't be able to hack a computer as an owl, you shouldn't be able to chop logs as a cougar, you shouldn't be able to plant seeds as a deer, and so on.Picking up items is tricky. I was originally thinking of allowing wield but banning wear and pick up (with the idea that you can carry one thing in your mouth), but since limbs are abstract and there's nothing stopping you from transferring the item into your bag once you pick it up, I banned wield too. I may change my mind if I can figure out how to force you to keep it in your mouth once you pick it up, or if banning ACT_INSERT_ITEM turns out to ban moving it around your inventory too.
While writing this I had the idea of making everything in your inventory
SEMITANGIBLE
and greatly reducing your carrying capacity based on form, but that's a big change so it would have to be another PR, and also I thinkSEMITANGIBLE
only affects encumbrance and not weight so it might not work at all.Describe alternatives you've considered
Testing
Makes things much better but doesn't solve all problems--the part above about wear/wield shouldn't be planned around since whether you can pick up/drop/wear/wield is inconsistent. Most of the time it stops you, but at least once I was able to put on an emergency blanket (quite the feat as a deer). Still, much better than before. I wasn't able to drive a car, apply a bandage, or move furniture, so the easy solution is to use the forms as they were designed for (movement/combat) and transform back if you want opposable thumbs.
Additional context