Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm/Xedra Evolved] Animals can't do that #78472

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 10, 2024

Summary

Mods "[Magiclysm/Xedra Evolved] Animals can't do that"

Purpose of change

I've been adding a lot of ability to shapechange into various animals in different mods and part of my goal is reasonable restrictions on what those animals can do. Code support will have to wait for limbification, but in the meantime, u_cancel_activity can cover a lot of things.

Describe the solution

Add an EoC that runs u_cancel_activity shortly after starting a huge variety of activities. You shouldn't be able to hack a computer as an owl, you shouldn't be able to chop logs as a cougar, you shouldn't be able to plant seeds as a deer, and so on.

Picking up items is tricky. I was originally thinking of allowing wield but banning wear and pick up (with the idea that you can carry one thing in your mouth), but since limbs are abstract and there's nothing stopping you from transferring the item into your bag once you pick it up, I banned wield too. I may change my mind if I can figure out how to force you to keep it in your mouth once you pick it up, or if banning ACT_INSERT_ITEM turns out to ban moving it around your inventory too.

While writing this I had the idea of making everything in your inventory SEMITANGIBLE and greatly reducing your carrying capacity based on form, but that's a big change so it would have to be another PR, and also I think SEMITANGIBLE only affects encumbrance and not weight so it might not work at all.

Describe alternatives you've considered

Testing

Makes things much better but doesn't solve all problems--the part above about wear/wield shouldn't be planned around since whether you can pick up/drop/wear/wield is inconsistent. Most of the time it stops you, but at least once I was able to put on an emergency blanket (quite the feat as a deer). Still, much better than before. I wasn't able to drive a car, apply a bandage, or move furniture, so the easy solution is to use the forms as they were designed for (movement/combat) and transform back if you want opposable thumbs.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft December 10, 2024 17:08
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Dec 10, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 10, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review December 11, 2024 02:19
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 11, 2024
@Night-Pryanik Night-Pryanik merged commit 5fcf89d into CleverRaven:master Dec 11, 2024
21 of 23 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 11, 2024
@Standing-Storm Standing-Storm deleted the animals-cant-do-that branch December 11, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants