Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cut pepper byproduct to bell pepper & chili pepper seeds recipes #78449

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

FauxNight
Copy link
Contributor

@FauxNight FauxNight commented Dec 9, 2024

Summary

Bugfixes "Add cut pepper byproduct to bell pepper & chili pepper seeds recipes"

Purpose of change

Crafting bell pepper seeds or chili pepper seeds instead of disassembling them only gives seeds and not the cut versions of the peppers like it should.

Describe the solution

Added cut bell pepper and cut chili pepper as byproducts to the bell pepper seeds and chili pepper seeds recipes respectively.

Describe alternatives you've considered

None

Testing

Crafted bell pepper seeds and chili pepper seeds in game.

Additional context

Added cut chili pepper as a byproduct of crafting chili pepper seeds
Added cut bell pepper as a byproduct of crafting bell pepper seeds
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 9, 2024
@moxian
Copy link
Contributor

moxian commented Dec 10, 2024

I think it would be better to outright remove those recipes, so as not to clutter the crafting UI.

And if you have a strong opinion that they should stay, then I still think it would still be preferable to have a cut bell pepper recipe with seeds as byproduct than a bell pepper seeds recipe with cut pepper as byproduct. You are more likely to want cut bell pepper than its seeds. IMO at least.

@FauxNight
Copy link
Contributor Author

FauxNight commented Dec 10, 2024

I don't have a strong opinion on it, but this PR was just meant to fix an oversight and bring bell peppers and chili peppers in line with all other veggies with a cut version recipe. If these two recipes were outright removed, the ones for tomato, zucchini, pumpkin, etc. would also need to be removed, and I think that'd be out of scope.

I personally don't find they clutter the UI, though, since they all fall under the seeds tab of the crafting menu. There also is no reason you would want bell_pepper_cut over bell_pepper since functionally they're (intended to be) the exact same item just with the seeds removed for you to use.

@Night-Pryanik Night-Pryanik merged commit c5c8fa6 into CleverRaven:master Dec 10, 2024
22 of 27 checks passed
@FauxNight FauxNight deleted the pepperseeds branch December 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants