Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heavy lights use batteries #78374

Merged

Conversation

marilynias
Copy link
Contributor

@marilynias marilynias commented Dec 6, 2024

Summary

None

Purpose of change

The heavy flashlight couldn't be reloaded, even though the reference model used 4xAA Battery.
Also the heavy headlamp had some weird discrepencies, eg. was using pure energy without "NO_UNLOAD", "NO_RELOAD" flags and could not be plugged into any power-network.
fixes #78360

Describe the solution

Make heavy flashlight and heavy headlamp use medium Batteries, since we dont have any batteries in the 112 range and the comment for the medium battery specifically mentions the heavy flashlight.
To compensate for lost charge (112 vs 56), reduce consumption from 4 to 2 (~8hr runtime like reference model on high).

Add the link-up action to headlamp.

Ive also found a holiday item that uses pure energy without "NO_UNLOAD", "NO_RELOAD". I gave it a small battery.

Describe alternatives you've considered

keeping the inbuilt battery and just fixing the headlamp.

Testing

Spawn in heavy flashlight and battery,
can reload,
can turn on,
can be crafted into headlamp,
battery gets placed back in inventory,
can reload headlamp,
can plug into power network,
does charge.

####Additional context
for reference, last balance was #77667
IMO having heavy battery use batteries is more important than the fact, that it uses the same battery as the normal flashlight / the hackery of reducing its consumption. As long as we cant stack batteries those kinds of compromises will be necessary.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 6, 2024
@Maleclypse Maleclypse merged commit cfe9f6c into CleverRaven:master Dec 7, 2024
24 of 30 checks passed
@marilynias marilynias deleted the heavy-headlamp-battery-fix branch December 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heavy Duty Headlamp can not be charged
2 participants