Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the category of furniture items back to other #78369

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

In #77838 I accidentally made their category weapons, because they had no field to overwrite it and by giving them damage values the game automatically assigns weapons as the category

Describe the solution

Switch it back

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 6, 2024
@Maddremor
Copy link
Contributor

Consider adding furniture as a separate category, other feels quite bloated to me.

@Karol1223 Karol1223 force-pushed the chairs-arent-weapons branch from a589ee8 to a2e2c83 Compare December 6, 2024 10:15
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 6, 2024
@Karol1223
Copy link
Contributor Author

Consider adding furniture as a separate category, other feels quite bloated to me.

I don't think I can from the JSON side. Even if I did, I'm not sure we have enough furniture items yet to warrant it.

@Maleclypse
Copy link
Member

Maleclypse from the high rope with the chair, splitting the zombies skull wide open. There's brains everywhere, the crowd goes wild!

@Maleclypse Maleclypse merged commit c5cf777 into CleverRaven:master Dec 8, 2024
20 of 24 checks passed
@Karol1223 Karol1223 deleted the chairs-arent-weapons branch December 8, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants