-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a bong and its spawn conditions #78342
Conversation
This adds a new item, the water pipe, which represents glass water pipes, also known as "Bongs" and spawn conditions for them.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DSeyka <[email protected]>
I wasn't aware this was not already present in game. |
Yeah I was surprised too. As for indestructibility, I only really have my own anecdotes but I've had enough sheepish people walk up to me saying "yeah...I broke my bong...." when I worked in the cannabis industry that I cannot imagine it would last long being used as a bludgeon. Thick glass can only get you so far. |
Added variants
Upped spawn in 'stoner' group.
Co-authored-by: Maleclypse <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
changing to-hit
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me so far. I'd also ask for a disassembly to go in hand with other simple glass items (so blind easy, 1 second, throwing it on the ground to shatter it to shards) but it's not technically necessary to go through.
I figure this can be a followup PR as it looks like this person was a new contributor and had to request test approvals each time they updated the PR. |
Summary
Content "Add water pipe and spawns"
Purpose of change
Adding a water pipe, also known as a "bong" to the game - an item that can be used for smoking, and also can contain some water. This specific example is based off of mass-manufactured water pipes which are often found in headshops, sold under the pretense of being used for tobacco - even in legalized areas, you find bongs being sold with labels saying something to the effect of 'tobacco use only' due to manufacture often taking place in countries where cannabis is highly illegal.
Describe the solution
Adds a tool with the capacity to hold 500 ml of liquid, be used for smoking, boiling, and other purposes. A merger between a 0.5 liter jar and a tobacco pipe, code-wise.
Describe alternatives you've considered
Suffering through my stoner character using a dry pipe. Clearly, this breaks my immersion.
Testing
I tested cooking (was able to boil water and make soup without crashes), containing (held items just fine), smoking, and spawning. It can be used without issue when full of liquid, replicating the actual process of smoking with a water pipe.
Additional context
This was a modding experiment that got approval from the community and people asked if I would add it. I decided to give it a swing.