Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic: bugfix spawn ethereal item effect #78332

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

b3brodie
Copy link
Contributor

@b3brodie b3brodie commented Dec 4, 2024

Summary

Bugfixes "Stop item spawning magic from putting items on ground when a player is available"

Purpose of change

Bugfix that items wouldn't automatically be given to a character
Fixes #78327

Describe the solution

Switches the check to look for characters in general instead of specifically an npc. Also, moves the algorithm to use the found character instead of assuming that the player is targeted.

Describe alternatives you've considered

N/A

Testing

Spawning item on ground works correctly
Spawning item for self works correctly
Spawning an item on an npc works correctly

Additional context

@github-actions github-actions bot requested a review from KorGgenT December 4, 2024 04:27
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Enchantments / Spells Enchantments and spells <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Dec 4, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 4, 2024
@Maleclypse Maleclypse merged commit c2fdece into CleverRaven:master Dec 4, 2024
21 of 26 checks passed
@b3brodie b3brodie deleted the magic_spawn branch December 5, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summoning weapons spawns them dropped
2 participants