Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
External options aren't even mentioned in documentation
Loading comments and storing them twice is very dumb
Describe the solution
Renames
game_balance.json
toexternal_options.json
bc most of them have nothing to do with game balance, all the external options randomly just got lumped into it at some point.Adds simple documentation mainly pointing modders to
/core/external_options.json
Changes the
"info"
comments to"//"
comments and removes dupes in mods as they're unlikely to remain up to dateDescribe alternatives you've considered
Make a table of id(name), type, default and a description of each external option rather than having the comments in the dda file but that felt redundant with how simple the type currently is, the file is pretty much already a table that doesn't need maintaining separately.
Testing
Game compiles and loads
Additional context