Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather works with region overlay #78234

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Nov 29, 2024

Summary

None

Purpose of change

Everything in region settings should work with overlay
Needed for the PRs I'm splitting #73602 into

Describe the solution

What it says on the tin

Describe alternatives you've considered

Seperate weather generator settings from weather generator so they follow the same pattern as everything else, see first commit

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Weather Rain, snow, portal storms and non-temperature environment json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 29, 2024
@Maleclypse Maleclypse merged commit 3b34699 into CleverRaven:master Nov 30, 2024
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Weather Rain, snow, portal storms and non-temperature environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants