Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hobblebush and autumn olive #78227

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

NetSysFire
Copy link
Member

@NetSysFire NetSysFire commented Nov 29, 2024

Summary

Content "Add hobblebush and autumn olive"

Purpose of change

The native flora saga continues. The next two plants I felt compelled to work on are hobblebush and autumn olive.

Describe the solution

  • Add hobblebush, which grows mostly in dense forests and has a slightly higher move_cost_mod than other shrubs
  • Add autumn olive, an invasive and apparently also super nutritious plant that likes fields and forest edges
  • Add stuff which I added in previous things to conditional names in some fruit preserves as I have forgotten that

Describe alternatives you've considered

Testing

Applied changes locally and located plus harvested both plants where they occured naturally. Harvested hobblebush with survival 10 debug character, noticed I got 6, went to look up documentation and saw what scale_num does and nerfed it for the entries I have been adding. Got cargo-culted a lot, can be a task for a future PR to clean up that whole file.

Additional context

Sources:

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 29, 2024
@Night-Pryanik
Copy link
Contributor

Could you please also update Magiclysm and XE, like in #78221?

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • %s, hobbleberry

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@NetSysFire
Copy link
Member Author

Could you please also update Magiclysm and XE, like in #78221?

Sure but honestly, these spells should use terrain or furniture groups as I am already adding the stuff to those. The only thing the terrain and furniture groups do not feature are the harvested terrains. This way the spells need way less maintenance.

@github-actions github-actions bot requested a review from KorGgenT November 29, 2024 04:42
@github-actions github-actions bot added Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved labels Nov 29, 2024
@github-actions github-actions bot requested a review from Maleclypse November 29, 2024 04:42
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 29, 2024
@Night-Pryanik Night-Pryanik merged commit 91e1ec8 into CleverRaven:master Nov 29, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants