Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More alarmed windows #78212

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

Milopetilo
Copy link
Contributor

Summary

None

Purpose of change

People in the discord noticed houses had an unusual amount of windows without curtains. This is cause by the fact that there were no alarmed windows with curtains, and that I forgot to adjust the ratio of alarmed:not alarmed houses from 50:50 to 25:75.

Describe the solution

Add in alarmed version of all the windows used in houses and make the palette use those.

Describe alternatives you've considered

Testing

Game loads, houses spawn with and without alarms, bashing alarmed windows sets off alarms, opening and closing windows and curtains keeps the alarm.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 28, 2024
@Night-Pryanik Night-Pryanik merged commit d5420b8 into CleverRaven:master Nov 29, 2024
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants