Corrected 'check_support' #78209
Merged
Corrected 'check_support' #78209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Crafting / Construction / Recipes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #78202, i.e. inability to construct roof on top of doors (and windows).
Describe the solution
Replace check of the non working "CONNECT_WITH_WALL" flag with checks for the "DOOR" and "WINDOW" flags.
Describe alternatives you've considered
See if there are other flags (beyond DOOR and WINDOW) that might be applicable. I've failed to find any. Embrasures are flagged as walls, and so work.
Testing
Loading the bug report save and being able to build a roof over the door, the next wall segment, and the window, but not over the floor, except in the corner, where it's supported by roofs on both sides.
Additional context