fix crash on keybind reset in UILIST context #78198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The crash occured in all contexts where there were no defaults. UILIST is one of them.
github-actions
bot
added
[C++]
|
Clang tidy will fail. I want to see if it allows auto for iterators. It probably does not. Edit: Wow, it does! |
github-actions
bot
added
the
astyled
Brambor
force-pushed
the
fix-crash-kb-reset
branch
from
5992b88 to
c460baa
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "crash on keybind reset in UILIST"
Purpose of change
UILIST.*is one of them.TEXT.*context, but I dare to say it is impossible to open the keybinding menu for it. I tried rebinding the keybinding menu to ctrl+M, but that didn't work either.Describe the solution
findthenat), that is all the iterator things.Describe alternatives you've considered
Testing
Additional context
I don't know why I didn't look into that issue before. I even commented on it! Thanks @ZhilkinSerg.