Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Add treesung gear #78197

Merged
merged 17 commits into from
Dec 8, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Nov 27, 2024

Summary

Mods "[Xedra Evolved] Add treesung gear"

Purpose of change

A while back I made a spell for Arvore to shape furniture out of living wood, with a set of armor as a bonus. Since then I've also made Arvore severely allergic to iron, greatly limiting their weapon choices. So what weapons do they use?

Treesung ones.

Describe the solution

Add a variety of treesung weapons for Arvore to use, mostly bashing or piercing (mace, staves, spears, etc), but with a few blades sharpened through the magic. The primary disadvantage is that treesung gear cannot be repaired, and blades are not as durable as metal ones (even with magic strengthening them they dull more easily). Also add treesung bows and arrows.

To do:

  • Add recipes
  • Add recipes to the EoC that teaches them
  • Add some gear to the existing changelings at a low chance (they'd probably use moon's tears gear but some might have treesung gear instead)

Future PR: more Arvore enemies that use this gear and drop it when defeated.

Arvore can also use moon's tears gear if they find some, they just can't make it themselves.

Describe alternatives you've considered

Testing

Untitled2

Recipes and item exist.

Additional context

To do future: special Salamander items made of frozen flames.

@Standing-Storm Standing-Storm marked this pull request as draft November 27, 2024 23:59
@github-actions github-actions bot requested a review from Maleclypse November 28, 2024 00:00
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Melee Melee weapons, tactics, techniques, reach attack Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions labels Nov 28, 2024
@github-actions github-actions bot added the Items: Armor / Clothing Armor and clothing label Nov 28, 2024
@github-actions github-actions bot added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A wooden shortbow with a thin vine for a string, all formed from a single piece of wood, with twists and curves like it grew in place rather than being made.
  • treesung shortbow

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 2, 2024
@github-actions github-actions bot added the EOC: Effects On Condition Anything concerning Effects On Condition label Dec 3, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 4, 2024
@github-actions github-actions bot added Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. labels Dec 5, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review December 5, 2024 03:16
data/mods/Xedra_Evolved/items/armor/armor.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/items/melee_treesung.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/items/melee_treesung.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/items/melee_treesung.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/items/melee_treesung.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 5, 2024
@Standing-Storm
Copy link
Contributor Author

Thank you for the detailed review!

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 6, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 6, 2024
@Maleclypse Maleclypse merged commit 9200e5c into CleverRaven:master Dec 8, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the Treesung-gear branch December 8, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants