Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Fix Elevator Controls in Urban Greenhouse #78192

Merged

Conversation

QuillInkwell
Copy link
Contributor

Summary

Mods "[Aftershock] Fix Elevator Controls in Urban Greenhouse"

Purpose of change

At some point, likely due to palette changes I made myself, the elevator controls on the top floor of the Urban farm started spawning with an Entertainment center. This makes the controls completely unusable and is of course very out of place.
image

Describe the solution

I changed the map key for the Elevator controls to one of the keys specifically left unreserved for maps to use.
image

Describe alternatives you've considered

I could have left the bug in. Used a different map key. Or changed the key on the palette itself. It's also worth considering giving elevator controls and elevators their own reserved keys in something like the structure palette.

Testing

Reset my world, teleported to the structure, verified elevator controls spawning nix the entertainment center.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod labels Nov 27, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 27, 2024
@John-Candlebury John-Candlebury merged commit d16889e into CleverRaven:master Nov 28, 2024
20 of 26 checks passed
@QuillInkwell QuillInkwell deleted the afs_fix_urban_greenhouse branch December 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants