Add tupelo and nannyberry trees

[NetSysFire]

Summary

Content "Add tupelo and nannyberry trees"

Purpose of change

More native flora so we can eventually replace all those orchard-grade random fruit trees with just those. There is no nutrition information for those on the web, like most lesser known foraged foods, so I copy values from elderberries as they are the closest resemblance. As this is literally just a copy-from this is trivial to change however.

Describe the solution

• Add tupelo and nannyberry trees.
• Add item, harvest and regional mapgen entry for them, add them to fruit leather and dehydrated fruit

Describe alternatives you've considered

Testing

Applied changes locally. I was able to find both trees in swamps ingame and harvested them. The fruits can be crafted with, too, as intended.

Additional context

What do I do next? Maybe black cherry. There are also the wild raisins and foxgrape, another viburnum like nannyberry.

Edit: Forgot to paste my sources lol

• https://gobotany.nativeplanttrust.org/species/nyssa/sylvatica/
• https://gobotany.nativeplanttrust.org/species/viburnum/lentago/
• https://www.eattheweeds.com/nyssus-tart-botanical-tangles-2/
• https://eattheplanet.org/black-tupelo-an-unknown-native-fruit-tree/
• https://practicalselfreliance.com/nannyberry-viburnum-lentago/
• https://foragerchef.com/nannyberries/
• https://plants.ces.ncsu.edu/plants/viburnum-lentago/

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• %s, nannyberries
• Some dark blue nannyberries, tasting like prunes mixed with banana.
• handful of nannyberries
• handfuls of nannyberries
• nannyberry tree

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[ampersand55]

What do I do next? Maybe black cherry. There are also the wild raisins and foxgrape, another viburnum like nannyberry.

With all these foraging options, it's a bit weird that we only have one type of named mushroom in the game, morels.

Some common New England mushrooms, besides morels, are:

• Oyster Mushrooms (Pleurotus ostreatus)
• Chicken of The Woods (Laetiporus sulphureus)
• Hen of the Woods (Grifola frondosa)
• Chanterelles (Cantharellus spp.)
• Black Trumpet (Craterellus cornucopioides)
• Lion's Mane (Hericium erinaceus)
• Boletes (Boletus spp.)
• Lobster Mushroom (Hypomyces lactifluorum)
• Puffballs (Calvatia spp., Lycoperdon spp.)
• Winecap (Stropharia rugoso-annulata)

[NetSysFire]

I looked into mushrooms and the difficulty there is id'ing those as there is a much, much greater risk into running something super dangerous there as compared to trees and we do not support conditional item names and descriptions. Plus I am currently working on good replacements regarding nutrition and no matter what mushroom, these usually do not have much calories. So adding those is flavor, not utility.

It would be super fun to model dangerous or even deadly mushroom effects using the vitamin system however. That is for later though.

[ampersand55]

I looked into mushrooms and the difficulty there is id'ing those as there is a much, much greater risk into running something super dangerous there as compared to trees and we do not support conditional item names and descriptions.

There's already some support for poisonous look-alikes being foraged with the HIDDEN_POISON and FORAGE_POISON flags. I'm not sure they are functional though.

Many of the mushrooms I listed are quite distinct and can't really be mistaken for any poisonous mushrooms. Especially Chicken of The Woods, Hen of the Woods, Lion's Mane, Lobster Mushrooms and Puffballs. The most common types of poisonous mushrooms in New England that could be mistaken for an edible mushroom would be some type of false morel, and the morel is already in the game.

Besides, any type of foraging of plants you don't recognize can be dangerous. you could confuse e.g. black nightshade berries with other black berries or baneberries for other red berries.

Another foraging suggestion, some poisonous berries such as black nightshade berries, baneberries and winterberries.

Plus I am currently working on good replacements regarding nutrition and no matter what mushroom, these usually do not have much calories.

They have a low amount of calories per mushroom as mush of the volume is just water and air, but that just means you just need more of them per serving. Mushrooms generally grow in droves. I sometimes go picking chantarells in Sweden with my family, and on a good day I can pick about 5 kg chantarells per hour, which is ~1500 calories. But of course, picking berries is more calorie efficient.

It would be super fun to model dangerous or even deadly mushroom effects using the vitamin system however. That is for later though.

That would indeed be super fun. However in the meantime there's the "Toxins" vitamin that's is already being used generically to represent the poison in mayapples.

[NetSysFire]

Please make a dedicated issue about this. Besides, there are enough shrooms that are poisonous and a spoiled big city evacuee will not know them. Even in real life there are many cases of unintentional mushroom poisoning.

FORAGE_POISON is meh because that is just generic poisoning which you can not customize. You can not even customize how often poisoning occurs with that flag.
I did not know about HIDDEN_POISON however. But all that as a discussion in a feature request please.