Increased weight of zombie hulk

[Night-Pryanik]

Summary

Bugfixes "Increased weight of zombie hulk"

Purpose of change

• Closes Big zombies' corpses have unrealistically low density #40076.

Describe the solution

Increased weight of zombie hulk from 200 to 1000 kilograms.

Describe alternatives you've considered

None.

Testing

Debug-spawned zombie hulk, killed it, checked its corpse's weight.

Additional context

None.

[SirPendrak]

Mass of 200kg seems very low.

[Maleclypse]

I'm not seeing the message logs for the errors but I'm wondering if Hulk weight is an important part of the failing tests?

(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> Martial_art_technique_conditionals
(~[slow] ~[.],starting_items)=>   Test sweep
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> ../tests/martial_art_test.cpp:163
(~[slow] ~[.],starting_items)=> ...............................................................................
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> ../tests/martial_art_test.cpp:180: FAILED:
(~[slow] ~[.],starting_items)=>   CHECK( !dude.evaluate_technique( tec, target_2, dude.used_weapon(), false, false, false ).has_value() )
(~[slow] ~[.],starting_items)=> with expansion:
Error: (~[slow] ~[.],starting_items)=>   false
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> Martial_art_technique_conditionals
(~[slow] ~[.],starting_items)=>   Test knockback
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> ../tests/martial_art_test.cpp:216
(~[slow] ~[.],starting_items)=> ...............................................................................
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> ../tests/martial_art_test.cpp:235: FAILED:
(~[slow] ~[.],starting_items)=>   CHECK( !dude.evaluate_technique( tec, target_2, dude.used_weapon(), false, false, false ).has_value() )
(~[slow] ~[.],starting_items)=> with expansion:
Error: (~[slow] ~[.],starting_items)=>   false
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> Log messages during failed test:

[Night-Pryanik]

I'm not sure why are we checking for failing a sweep and knockback techniques versus big zombies. I see two solutions here:

• require success instead of fail;
• find some other big zombie (with wrong json-defined size to pass the test?).

[Maleclypse]

I'm not sure why are we checking for failing a sweep and knockback techniques versus big zombies. I see two solutions here:

* require success instead of fail;

* find some other big zombie (with wrong json-defined size to pass the test?).

If I understand correctly we are checking to make sure that big monsters can't be swept or thrown. Could the size be made equal or greater to 5?

[Night-Pryanik]

Could the size be made equal or greater to 5?

Tests failing not because of wrong size. It's because game says that it's possible to sweep or throw a big monster, but tests require it shouldn't be possible. Contradiction.

[RenechCDDA]

This changes the hulk's size from HUGE to LARGE. Maybe we could just say sixteen men instead?

I don't see a lot of value in changing around the game balance and test coverage because a description wasn't 100% accurate.

[esotericist]

the hulk's size should not be changing here. increase the weight to fix the density, change the description if the inconsistency really bothers you, but it should be kept at the original size.

Tests failing not because of wrong size. It's because game says that it's possible to sweep or throw a big monster, but tests require it shouldn't be possible. Contradiction.

there wasn't a contradiction until you adjusted the size then adjusted the tests that were there to make sure the size was expected.

this sort of thing is exactly why the tests are there, so that someone doesn't go changing parameters in a way that change game balance casually. just hammering the tests to be quiet without stopping to ask "should i be changing the game balance on this?" is not the way to go about things.

[Maleclypse]

Testing closing to kick the delayed test