[MoM/XE] Add deactivate_conditions to recurring EoCs that don't need to recur for everyone #78161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
json-styled
|
@Standing-Storm could you please resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM/XE] Add deactivate_conditions to recurring EoCs that don't need to recur for everyone"
Purpose of change
My save crashed and while seeing if EoCs were causing it I saw a few recurring EoCs in the save that don't need to be there and could use some
deactivate_conditionsDescribe the solution
Add
deactivate_conditions to various mod EoCs. These are things likeEOC_INVENTOR_RECIPE_GAIN(gives you your first Inventor recipe in XE, no one but an Inventor will ever need it) orEOC_CLAIR_RAD_SENSE_OUTSIDE_RECURRING(part of a Clairsentient power in MoM, not necessary for anyone who isn't a Clairsentient).All recurring EoCs are turned back on if you gain a new trait, so I made sure the deactivate conditions were all trait-based.
Describe alternatives you've considered
Testing
Additional context