Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ImGui version to 1.91.5 #78144

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Upgrade ImGui version to 1.91.5 #78144

merged 2 commits into from
Nov 28, 2024

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

Infrastructure "Upgrade ImGui to version to 1.91.5"

Purpose of change

Allow easier ImGui upgrades in the future. Also add missing license file.

Describe the solution

Upgraded ImGui to latest version and apply DDA/ImTui specific patches in a separate commit.

Additional context

We might want to migrate to docking branch (https://github.com/ocornut/imgui/tree/docking) in the future once more menus are migrated to imgui.

@github-actions github-actions bot added the Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style label Nov 25, 2024
@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds json-styled JSON lint passed, label assigned by github actions labels Nov 25, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Nov 25, 2024
@github-actions github-actions bot added the Code: Build Issues regarding different builds and build environments label Nov 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 25, 2024
@Brambor
Copy link
Contributor

Brambor commented Nov 27, 2024

@Maleclypse Maleclypse merged commit 7df1b91 into CleverRaven:master Nov 28, 2024
20 of 27 checks passed
@Maleclypse Maleclypse mentioned this pull request Nov 28, 2024
Closed
@Brambor Brambor mentioned this pull request Nov 29, 2024
Closed
@moxian moxian mentioned this pull request Dec 3, 2024
Open
@ZhilkinSerg ZhilkinSerg deleted the imgui-upgrade branch December 3, 2024 17:54
@ghiknt ghiknt mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqrause mqrause mqrause left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhilkinSerg @Brambor @mqrause @Maleclypse