-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enchantify special vision [2/2] #78080
enchantify special vision [2/2] #78080
Conversation
Would it be possible to change the range of a given special vision without overwriting it? Let's say you have two items, each giving thermal vision; one adds 10 tiles, the other adds 2. Will they give 10 or 12 tiles of thermal vision together? It is my understanding that one could do so with the old format. |
The consequence of having this system is that each vision is it's own instance, and they cannot be additive UPD: after discussion in discord, Storm (and mine) decision is to not make it stackable |
4d76680
to
904f594
Compare
as part of this pr, i made u_scope_obstruct_npc condition, as an attempt to replicate #59477 UPD: i ultimately decided to go with my previous approach of it being code-driven, not condition-driven |
213cf5c
to
f49b088
Compare
f49b088
to
d682933
Compare
Summary
None
Purpose of change
Continuation of #77770
Describe the solution
replace SIGHT_RANGE_ELECTRIC, MOTION_VISION_RANGE, SIGHT_RANGE_FAE, SIGHT_RANGE_NETHER, SIGHT_RANGE_MINDS with enchantment vision
use translation type
improve code somewhat
curses support
Testing
Thermal vision shows ascii support
Using magiclysm tremorsense with creature and flying creature