Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enchantify special vision [2/2] #78080

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Nov 22, 2024

Summary

None

Purpose of change

Continuation of #77770

Describe the solution

replace SIGHT_RANGE_ELECTRIC, MOTION_VISION_RANGE, SIGHT_RANGE_FAE, SIGHT_RANGE_NETHER, SIGHT_RANGE_MINDS with enchantment vision
use translation type
improve code somewhat
curses support

Testing

Thermal vision shows ascii support
image

Using magiclysm tremorsense with creature and flying creature
image
image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved Mods: Bombastic Perks Mods: Mind Over Matter json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 22, 2024
@Hyperseeker
Copy link
Contributor

Would it be possible to change the range of a given special vision without overwriting it? Let's say you have two items, each giving thermal vision; one adds 10 tiles, the other adds 2. Will they give 10 or 12 tiles of thermal vision together? It is my understanding that one could do so with the old format.

@GuardianDll
Copy link
Member Author

GuardianDll commented Nov 22, 2024

The consequence of having this system is that each vision is it's own instance, and they cannot be additive
Meaning if you have one thermal vision that has 10 tiles, and another that has 2 tiles, that would be it
I thought about stacking before, but deemed it to be too messy to deal with, but someone else can implement it of course
That is, unless @Standing-Storm tell me it is important for them to be able to combine multiple of visions

UPD: after discussion in discord, Storm (and mine) decision is to not make it stackable

@GuardianDll GuardianDll force-pushed the vision_stuff_part_2 branch 3 times, most recently from 4d76680 to 904f594 Compare November 23, 2024 10:29
@GuardianDll
Copy link
Member Author

GuardianDll commented Nov 23, 2024

as part of this pr, i made u_scope_obstruct_npc condition, as an attempt to replicate #59477
for some reason it doesn't work :/
maybe someone has some insights?
https://github.com/CleverRaven/Cataclysm-DDA/pull/78080/files#diff-534f433e7a0b5ec5c233390037e131f3717e8aa5f347c47e650a65a1ddc95279R1425-R1438

UPD: i ultimately decided to go with my previous approach of it being code-driven, not condition-driven

@GuardianDll GuardianDll force-pushed the vision_stuff_part_2 branch 2 times, most recently from 213cf5c to f49b088 Compare November 24, 2024 15:31
@GuardianDll GuardianDll marked this pull request as ready for review November 24, 2024 15:31
@Night-Pryanik Night-Pryanik merged commit 71b3dbe into CleverRaven:master Nov 24, 2024
18 of 26 checks passed
@GuardianDll GuardianDll deleted the vision_stuff_part_2 branch November 24, 2024 17:56
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods: Bombastic Perks Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: Xedra Evolved Anything to do with Xedra Evolved Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants