Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix penentrating strike #78076

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

ampersand55
Copy link
Contributor

Summary

Bugfixes "Fix penetrating strike"

Purpose of change

Correction of my previous PR #77812.

I misunderstood how "arpen" worked and the technique ended up doing nothing as it just increased the default armor penetration 0 by 33%. I also didn't do enough testing to catch the error.

Describe the solution

There is no good way to increase armor penetration linearly, and how it's applied and how it interacts with weakpoints and crits (pierce crits have 33% armor penetration) is quite complicated, so I derived at a value after testing, which is a flat bonus to armor penetration of 2x melee skill.

As it scales scales with melee skill and adds a flat armor penetration value, it's especially strong for a character with high melee skill using a low damage weapon. When balancing, I've assumed a character with 0-3 melee skill has a wooden spear, a character with 4-6 melee skill has a knife spear and a character with 7+ melee skill has a qiang.

A 2 melee skill character with a wooden spear (18 pierce) that crit for 2x damage would do 36 base pierce damage + 4 armor penetration.

A 5 melee skill character with a knife spear (26 pierce) that crit for 2x damage would do 52 base pierce damage +10 armor penetration.

A 10 melee skill character with a qiang (43 pierce) that crit for 2x damage would do 86 base pierce damage +20 armor penetration.

Describe alternatives you've considered

Changing it to a stun, like the other weapon categories have.

Testing

Made a 8/8/8/8 debug characters with 5 or 10 in all skills, using wooden spears, knifes pears or qiangs and tested it against 55 zombie cops and 55 zombie soldiers.

Here screenshots of the damage log comparing a 8/8/8/8 character with 5 in all skills using a knife spear with penetrating strike and one with a generic crit technique against a zombie cop (6 armor):

image

image

There was a minimal change in damage against zombie soldiers with 20 stab armor.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 22, 2024
@Maleclypse Maleclypse merged commit 97dd2f5 into CleverRaven:master Nov 24, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants