-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Translate Complex Dialogue mod #77996
Conversation
b25155a
to
7763294
Compare
It won't let me resolve conflicts. I was trying to find a better translation for steel of the lake but no one knows what the heck Rubik meant by that anymore. |
82f3a20
to
15ded06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @jbytheway
ca8b5c4
to
9d7dc29
Compare
Co-authored-by: Valiant <[email protected]> Co-authored-by: Maleclypse <[email protected]>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
* Update Translate Complex Dialogue mod * Apply suggestions Co-authored-by: Valiant <[email protected]> Co-authored-by: Maleclypse <[email protected]> * Remove old file --------- Co-authored-by: Valiant <[email protected]> Co-authored-by: Maleclypse <[email protected]>
Summary
Infrastructure "Script for updating Translate Complex Dialogue mod"
Purpose of change
Tried to update the mod manually and replace monolithic strings with concatenation, oaoaasdjs too much work, wrote a script for semi-automatic update.
Describe the solution
This update script uses up-to-date strings and
//~
comments as "translation":Usage:
cd path/to/Cataclysm-DDA/
python3 tools/json_tools/update-translate-dialogue-mod.py
json_formatter.cgi
, checkdoc/JSON_STYLE.md
"//": "mod_update_script_compact"
to dynamic lines to make the script concatenate that line more compactly and without newlines, which is useful if the original dialog also uses concatenation.Describe alternatives you've considered
Testing
Game loads, dialogs work correctly. Looked at script output to see that it doesn't create invalid constructs as far as I can see.
Reuse of existing translations:
Compact version (the space at the beginning was added later):
Additional context