Add trait property to supress traits being granted at random in chargen #77953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
…en and assign to some extreme traits.
kevingranade
force-pushed
the
supress-traits-at-random-chargen
branch
from
2d52f69 to
bf3df08
Compare
github-actions
bot
added
the
BasicBuildPassed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Got a report of NPCs spawning with unexpected traits after #76935, which I believe expanded the traits that NPCs can have assigned to them.
Describe the solution
Add a property to mutations indicating they shouldn't be acquired at random at chargen time.
Adjusted random selection at chargen time to filter on this property.
Assigned new property to traits that shouldn't be randomly assigned, either to players or NPCs.
Testing
Need to run a quick test to generate a bunch of random NPCs and enumerate the traits they spawn with.