Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mics eoc changes #77941

Merged
merged 3 commits into from
Nov 21, 2024
Merged

mics eoc changes #77941

merged 3 commits into from
Nov 21, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Nov 17, 2024

Summary

None

Purpose of change

Few random EoC fixes here and there

Describe the solution

added ability for compare_string to compare more than 1 string; use it in a few instances for simpler syntax; added unit test to confirm it won't break silently
fix vitrified farm not triggering asap, as it was intended - it was caused by eoc triggering on overmap boundary cross, and aborting because the condition "you stand on terrain X" failing; now it queue itself until it can teleport you properly
fix EOC_DIVING_INTO_WATER_CHECK trying to run event eoc - it doesn't work like this, so i simplified it, and added messages to signalize you indeed scrub away stuff

Testing

CI, also visited the quiet farm to confirm it works correctly

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions labels Nov 17, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 17, 2024
@Night-Pryanik Night-Pryanik merged commit bb2c4ca into CleverRaven:master Nov 21, 2024
21 of 27 checks passed
@GuardianDll GuardianDll deleted the more_eoc_fixes branch November 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants