Revert the horizontal separator color back to dark-gray #77935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Revert horizontal separator color back to dark gray"
Purpose of change
#77842 made the imgui colors inherit from player-chosen colors, but it used blue as the color for horizontal separator in item description screen and the like instead of dark gray. I assume, accidentally, since there is no mention of such intent in the PR.
In the default fresh install the blue color is extremely bright and high contrast. It pulls attention towards itself and makes it hard [for me] to look at the item description pane for prolonged time.
This change reverts the horizontal separator color back to what it was pre-#77842
Images:
before #77842
current master:
with this PR in place:
(sidenote: I'm not sure what's going on with the fonts and why the switched to monospace now, but that's out of scope)
Describe the solution
Change the separator default color from
c_blue
toc_dark_gray
Describe alternatives you've considered
N/A
(Well, i did consider making it much easier to customize imgui, and unbinding the "separator color" from the pre-defined colors we have in color config, but realized that it might be a task beyond my abilities atm. Besides, this PR is just a simple bugfix)
Testing
Opened item description pane, took screenshot (above), was happy with the result.
Additional context
This will likely conflict with #77928 since we both touch the same file (i'm not sure how PR conflicts are handled in this project and if i need to do anything special here. cc @mqrause just in case)