Remove debug message in add_profession_items() causing basic build failure #77922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unintended magiclysm conflicts cause it to trigger rarely
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "remove debug message in add_profession_items()"
Purpose of change
In #77334, I assumed that for NPC generation, failing to wear/store initial profession items in
add_profession_items()was a problem. If any equipment couldn't be put on the NPC, adebugmsgwould fire.It turns out that Magiclysm (which is included in the Basic Build test CI) includes species as hobbies, some of which can't equip certain professions' items -- this is fine, but
add_profession_itemsstill gives a warning for e.g. aLIZARDFOLKnot being able to wear cleats.Describe the solution
Removes the
debugmsgfor failure to equip an NPC with all initial profession equipment inadd_profession_items().Describe alternatives you've considered
Ideally there'd be a return type for wear_item clothing that distinguishes between "can't wear because of overlap" vs. "can't wear because of biology", but I'm content just fixing the CI here.
Testing
Generated a Lizardfolk Football Player in Magiclysm, noted missing equipment but no debugmsg
Removing the debugmsg makes sure it cannot possibly show up again, but make sure basic build passes on this PR
Additional context
Apologies, I didn't know Magiclysm was in the CI, nor have I tried playing Magiclysm (yet)