Obsolete OM_MOVE #77917
Merged
Obsolete OM_MOVE #77917
+3
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
GuardianDll
force-pushed
the
obsolete_OM_MOVE
branch
from
7651bc9 to
b386906
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
There are two ways to run eoc when character crosses some boundary: eoc of type OM_MOVE, or eoc hooked to avatar_enters_omt event;
First one is barely used, second one used widely and allow using of additional context vars. Supreme way, i'd say. Let's stick to it
Describe the solution
Remove OM_MOVE type
Testing
No changes, the game compiles and loads properly
Additional context
Fun fact: both events run at the same time, and both events run event before actually stepping onto said OM